Add [unary_parenthesis_followed_by_cast]#10625
Closed
KisaragiEffective wants to merge 2 commits intorust-lang:masterfrom
Closed
Add [unary_parenthesis_followed_by_cast]#10625KisaragiEffective wants to merge 2 commits intorust-lang:masterfrom
unary_parenthesis_followed_by_cast]#10625KisaragiEffective wants to merge 2 commits intorust-lang:masterfrom
Conversation
Collaborator
|
r? @llogiq (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
KisaragiEffective
force-pushed
the
feature/unary_parenthesis_followed_by_cast
branch
from
3484a01 to
59c299a
Compare
Contributor
Author
|
(force-pushed due to lack of my GPG signature) |
Contributor
|
I'm curious why the |
Contributor
Author
|
@llogiq It seems current implementation doesn't handle |
Contributor
|
Yeah, fixing the false negative in rustc is a better solution. You can keep this PR open in case the other one doesn't go through. |
Contributor
Author
|
submitted rust-lang/rust#110189, I'm going to close this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check list:
.stderrfile)cargo testpasses locallycargo dev update_lintscargo dev fmtunresolved questions:
close #10557.
Please write a short comment explaining your change (or "none" for internal only changes)
changelog: Add [
unary_parenthesis_followed_by_cast]